Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Surrogate Modeling Toolbox Machine Learning (GENN) Models #1169

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Support for Surrogate Modeling Toolbox Machine Learning (GENN) Models #1169

merged 10 commits into from
Sep 29, 2023

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Sep 25, 2023

Fixes/Addresses:

Summary/Motivation:

Changes proposed in this PR:

  • Demonstrates how users can train/save Surrogate Modeling Toolbox gradient-enhanced neural network (GENN) models with custom objects and produce .pkl files compatible with the ML AI Plugin in FOQUS
  • Support for Surrogate Modeling Toolbox GENN models in FOQUS, including updates to the run methods, node properties, test framework, documentation and optional dependencies list

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Sep 25, 2023
@bpaul4
Copy link
Contributor Author

bpaul4 commented Sep 25, 2023 •
edited
Loading

There is one expected error. The "Build docs" check will fail until #1164 is merged, as the documentation in this PR includes a reference to a page that is added in the Gradient Generation PR. The "ReadTheDocs" check will fail for the same reason. The reference that doesn't exist yet is called gengrad.

@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Coverage Δ
foqus_lib/conftest.py 90.52% <ø> (ø)
foqus_lib/framework/ml_ai_models/mlaiSearch.py 82.92% <ø> (ø)
foqus_lib/framework/graph/node.py 62.37% <65.62%> (-0.25%) ⬇️

... and 15 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@bpaul4 bpaul4 added Priority:Normal Normal Priority Issue or PR ML/AI Machine Learning/Artificial Intelligence labels Sep 26, 2023
lbianchi-lbl
lbianchi-lbl reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I left one minor suggestion which is fully optional
  • The rest of the code and docs looks fine as far as I could tell from a quick skim

foqus_lib/framework/graph/node.py Outdated Show resolved Hide resolved
foqus_lib/framework/graph/node.py Outdated Show resolved Hide resolved
@bpaul4 bpaul4 requested a review from lbianchi-lbl September 29, 2023 14:23
@lbianchi-lbl
Copy link
Contributor

I've just checked, and the minor drop in code coverage seems to be coming from error handling code being added (and I'm not sure whether this is also due to part of the report still missing), so I'm merging this in.

@lbianchi-lbl lbianchi-lbl merged commit 10df746 into CCSI-Toolset:master Sep 29, 2023
15 of 16 checks passed
@bpaul4 bpaul4 deleted the mlai-smt-support branch March 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbianchi-lbl lbianchi-lbl lbianchi-lbl approved these changes

@ksbeattie ksbeattie Awaiting requested review from ksbeattie

Assignees

@bpaul4 bpaul4

Labels
ML/AI Machine Learning/Artificial Intelligence Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
EY23.4.1.H: Implement FOQUS support f...
Development

Successfully merging this pull request may close these issues.
2 participants
@bpaul4 @lbianchi-lbl